git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 06/12] MSVC: config.mak.uname: drop -D__USE_MINGW_ACCESS from compile definitions

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Apr 28, 2014, 15:32 UTC
Message-ID
<CABPQNSZhMCPyyKVX0AhpttJbEJ3uF4gUPR9gpN=DUcLLxviwPA@mail.gmail.com>
In-Reply-To
<1398693097-24651-7-git-send-email-marat@slonopotamus.org>
On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko <marat@slonopotamus.org> wrote:
> -D__USE_MINGW_ACCESS only affects MinGW and does nothing when
> MSVC is used.
Seems reasonable in itself.

But, doesn't this mean that our access are currently broken on MSVC? The comment about __USE_MINGW_ACCESS is:

/*  Old versions of MSVCRT access() just ignored X_OK, while the version
    shipped with Vista, returns an error code.  This will restore the
    old behaviour  */
This sounds like we should lift the access-fix up one abstraction, into Git.

But wait a minute. In Git for Windows, we already wrapped up access for unicode-support (03a102ff - "Win32: Unicode file name support (except dirent)"), doing the exact same thing already. This patch isn't upstreamed yet, though.

Sounds like there's some cleaning up left to do on our behalf :)
This clean-up makes sense regardless, though.
Previous: Marat RadchenkoNext: Marat Radchenko
Message 31 of 54 in “Towards MinGW(-W64) cross-compilation”
  1. Towards MinGW(-W64) cross-compilationMarat Radchenko, Apr 28, 2014
  2. 01/12 MINGW: config.mak.uname: add explicit way to request MinGW-buildMarat Radchenko, Apr 28, 2014
  3. Jonathan NiederApr 28, 2014
  4. 02/12 MINGW: compat/bswap.h: include stdint.hMarat Radchenko, Apr 28, 2014
  5. Erik Faye-LundApr 28, 2014
  6. Marat RadchenkoApr 28, 2014
  7. Erik Faye-LundApr 28, 2014
  8. 03/12 MINGW: compat/mingw.h: do not attempt to redefine lseek on mingw-w64Marat Radchenko, Apr 28, 2014
  9. Erik Faye-LundApr 28, 2014
  10. Marat RadchenkoApr 28, 2014
  11. Erik Faye-LundApr 28, 2014
  12. Torsten BögershausenApr 28, 2014
  13. Felipe ContrerasApr 28, 2014
  14. Erik Faye-LundApr 28, 2014
  15. 04/12 Makefile: introduce CROSS_COMPILE variableMarat Radchenko, Apr 28, 2014
  16. Jonathan NiederApr 28, 2014
  17. Felipe ContrerasApr 28, 2014
  18. Marat RadchenkoApr 28, 2014
  19. Jonathan NiederApr 28, 2014
  20. Marat RadchenkoApr 28, 2014
  21. Felipe ContrerasApr 28, 2014
  22. Marat RadchenkoApr 28, 2014
  23. Felipe ContrerasApr 28, 2014
  24. Jonathan NiederApr 28, 2014
  25. Felipe ContrerasApr 28, 2014
  26. 05/12 MINGW: git-compat-util.h: use inttypes.h for printf macros.Marat Radchenko, Apr 28, 2014
  27. Erik Faye-LundApr 28, 2014
  28. Marat RadchenkoApr 28, 2014
  29. Erik Faye-LundApr 28, 2014
  30. 06/12 MSVC: config.mak.uname: drop -D__USE_MINGW_ACCESS from compile definitionsMarat Radchenko, Apr 28, 2014
  31. Erik Faye-LundApr 28, 2014
  32. 07/12 MINGW: config.mak.uname: reorganize MINGW settingsMarat Radchenko, Apr 28, 2014
  33. Erik Faye-LundApr 28, 2014
  34. Marat RadchenkoApr 28, 2014
  35. Erik Faye-LundApr 28, 2014
  36. Marat RadchenkoApr 28, 2014
  37. 08/12 MINGW: config.mak.uname allow using CURL for non-msysGit buildsMarat Radchenko, Apr 28, 2014
  38. Erik Faye-LundApr 28, 2014
  39. Marat RadchenkoApr 28, 2014
  40. Erik Faye-LundApr 28, 2014
  41. 09/12 MINGW: config.mak.uname: drop -DNOGDIMarat Radchenko, Apr 28, 2014
  42. Erik Faye-LundApr 28, 2014
  43. 10/12 MINGW: config.mak.uname: drop USE_NED_ALLOCATORMarat Radchenko, Apr 28, 2014
  44. Erik Faye-LundApr 28, 2014
  45. Jonathan NiederApr 28, 2014
  46. Marat RadchenkoApr 29, 2014
  47. Felipe ContrerasApr 29, 2014
  48. Felipe ContrerasApr 28, 2014
  49. Philip OakleyApr 28, 2014
  50. 11/12 MINGW: do not fail at redefining pid_t on MinGW-W64Marat Radchenko, Apr 28, 2014
  51. Erik Faye-LundApr 28, 2014
  52. 12/12 MINGW: compat/mingw.h: drop fork() definitionMarat Radchenko, Apr 28, 2014
  53. Erik Faye-LundApr 28, 2014
  54. Erik Faye-LundApr 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.