Re: [PATCH v2 1/4] t4014: more tests about appending s-o-b lines
On Sat, Dec 1, 2012 at 11:06 PM, Torsten Bögershausen <tboegi@web.de> wrote:
Show 13 quoted lines
> On 22.11.12 17:38, Nguyễn Thái Ngọc Duy wrote:
>>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> ---
>> t/t4014-format-patch.sh | 145 ++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 145 insertions(+)
>> + echo -n subject | append_signoff >actual &&
>
>
> "echo -n" is not portable, and we use printf everywhere.
> I found one "echo -n" in line 996.
>
> Can we squeeze that in, before going to next?
I got it. I'll squash it into the next series.
-Brandon
Brandon Casey <drafnel@gmail.com>