git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Topics currently in the Stalled category

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Nov 22, 2012, 11:24 UTC
Message-ID
<CACsJy8BiJRK7N3_HZ2WXpMd1YkDSW00AxuYqiCWJgij+Kq6AiQ@mail.gmail.com>
In-Reply-To
<7vobirq0q2.fsf_-_@alter.siamese.dyndns.org>
On Wed, Nov 21, 2012 at 7:05 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
> * nd/unify-appending-of-s-o-b (2012-11-15) 1 commit
>  - Unify appending signoff in format-patch, commit and sequencer
>
>  I am not sure if the logic to refrain from adding a sign-off based
>  on the existing run of sign-offs is done correctly in this change.

I'm not sure what's the right logic here. The original code in format-patch has exactly one test just to verify that --signoff does _something_. There's another signoff code in git-am.sh and we should make sure at least the behavior is consistent. I guess I should start over by writing new tests to record the current behavior, then fixes and finally the unification. I think you can drop this for now.

-- 
Duy
Next: Nguyễn Thái Ngọc Duy
Message 1 of 9 in “Re: Topics currently in the Stalled category”
  1. Nguyen Thai Ngoc DuyNov 22, 2012
  2. 0/4 nd/unify-appending-of-s-o-bNguyễn Thái Ngọc Duy, Nov 22, 2012
  3. 1/4 t4014: more tests about appending s-o-b linesNguyễn Thái Ngọc Duy, Nov 22, 2012
  4. Torsten BögershausenDec 2, 2012
  5. Brandon CaseyDec 2, 2012
  6. 2/4 format-patch: stricter S-o-b detectionNguyễn Thái Ngọc Duy, Nov 22, 2012
  7. 3/4 format-patch: update append_signoff prototypeNguyễn Thái Ngọc Duy, Nov 22, 2012
  8. 4/4 Unify appending signoff in format-patch, commit and sequencerNguyễn Thái Ngọc Duy, Nov 22, 2012
  9. Junio C HamanoNov 24, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.