From: Brandon Casey <drafnel@gmail.com>
Date: Sun, 02 Dec 2012 08:03:54 GMT
Subject: Re: [PATCH v2 1/4] t4014: more tests about appending s-o-b lines
Message-ID: <CA+sFfMd-yvQpsfVEWYBk+70_05Ov5aX4xg8nNY0HPwHTVAK60Q@mail.gmail.com>
In-Reply-To: <50BAFE04.4080100@web.de>

On Sat, Dec 1, 2012 at 11:06 PM, Torsten Bögershausen <tboegi@web.de> wrote:
> On 22.11.12 17:38, Nguyễn Thái Ngọc Duy wrote:
>>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> ---
>>  t/t4014-format-patch.sh | 145 ++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 145 insertions(+)
>> +     echo -n subject | append_signoff >actual &&
>
>
> "echo -n" is not portable, and we use printf everywhere.
> I found one "echo -n" in line  996.
>
> Can we squeeze that in, before going to next?

I got it.  I'll squash it into the next series.

-Brandon