git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/4] nd/unify-appending-of-s-o-b

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Nov 22, 2012, 16:38 UTC
Message-ID
<1353602289-9418-1-git-send-email-pclouds@gmail.com>
In-Reply-To
<CACsJy8BiJRK7N3_HZ2WXpMd1YkDSW00AxuYqiCWJgij+Kq6AiQ@mail.gmail.com>

This round cherry-pick and commit only skip S-o-b if the last one is the same while format-patch skips it if the same one appears anywhere in S-o-b list. I don't have strong opinion about which way is more correct. Though if we decide to change format-patch behavior, the series may become a bit different.

Nguyễn Thái Ngọc Duy (4):
  t4014: more tests about appending s-o-b lines
  format-patch: stricter S-o-b detection
  format-patch: update append_signoff prototype
  Unify appending signoff in format-patch, commit and sequencer
 builtin/commit.c        |  10 ++-
 builtin/log.c           |  13 +---
 log-tree.c              |  66 +++++++++++++---
 log-tree.h              |   4 +
 revision.h              |   2 +-
 sequencer.c             |  65 +---------------
 sequencer.h             |   4 -
 t/t4014-format-patch.sh | 199 ++++++++++++++++++++++++++++++++++++++++++++++++
 t/t7501-commit.sh       |   2 +-
 9 files changed, 272 insertions(+), 93 deletions(-)
-- 
1.8.0.4.g5d0415a
Previous: Nguyen Thai Ngoc DuyNext: Nguyễn Thái Ngọc Duy
Message 2 of 9 in “Re: Topics currently in the Stalled category”
  1. Nguyen Thai Ngoc DuyNov 22, 2012
  2. 0/4 nd/unify-appending-of-s-o-bNguyễn Thái Ngọc Duy, Nov 22, 2012
  3. 1/4 t4014: more tests about appending s-o-b linesNguyễn Thái Ngọc Duy, Nov 22, 2012
  4. Torsten BögershausenDec 2, 2012
  5. Brandon CaseyDec 2, 2012
  6. 2/4 format-patch: stricter S-o-b detectionNguyễn Thái Ngọc Duy, Nov 22, 2012
  7. 3/4 format-patch: update append_signoff prototypeNguyễn Thái Ngọc Duy, Nov 22, 2012
  8. 4/4 Unify appending signoff in format-patch, commit and sequencerNguyễn Thái Ngọc Duy, Nov 22, 2012
  9. Junio C HamanoNov 24, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.