git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/4] nd/unify-appending-of-s-o-b

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 24, 2012, 02:05 UTC
Message-ID
<7vtxsfzrfr.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1353602289-9418-1-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
> This round cherry-pick and commit only skip S-o-b if the last one is
> the same...

That sounds sensible. When the user asks us to add sign-off, we should honor it, unless it is known that adding one is absolutely unnecessary, which is "it already exists as the last one". Ignoring all other cases will lose information.

Among the non-merge commits in the kernel history, you see about 500 such commits where the same contributor signs off the patch more than once, recording the flow of the patch; 106a4ee258 seems to be the most recent example.

Thanks.
Previous: Nguyễn Thái Ngọc Duy
Message 9 of 9 in “Re: Topics currently in the Stalled category”
  1. Nguyen Thai Ngoc DuyNov 22, 2012
  2. 0/4 nd/unify-appending-of-s-o-bNguyễn Thái Ngọc Duy, Nov 22, 2012
  3. 1/4 t4014: more tests about appending s-o-b linesNguyễn Thái Ngọc Duy, Nov 22, 2012
  4. Torsten BögershausenDec 2, 2012
  5. Brandon CaseyDec 2, 2012
  6. 2/4 format-patch: stricter S-o-b detectionNguyễn Thái Ngọc Duy, Nov 22, 2012
  7. 3/4 format-patch: update append_signoff prototypeNguyễn Thái Ngọc Duy, Nov 22, 2012
  8. 4/4 Unify appending signoff in format-patch, commit and sequencerNguyễn Thái Ngọc Duy, Nov 22, 2012
  9. Junio C HamanoNov 24, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.