Re: [GSoC PATCH v2 0/4] teach git repo info to handle path keys
Show 8 quoted lines
>
> I prefer `.(absolute|relative)` at the end. `path.gitdir.relative`
> means that we have a collection of paths, in those collections we
> have gitdir that can be relative or absolute, and we want the
> relative. `path.relative.gitdir` means that we have a collection
> of relative paths and from those we're picking gitdir. The first
> feels more natural.
>
Show 5 quoted lines
> PS: this is a nitpick, but it would be really helpful if you provide
> a range-diff in the cover letter. Check the usage of `--range-diff`
> in git-format-patch documentation (this flag also works for
> git-send-email). Or, if you prefer, you can generate it by running
> `git range-diff` and copying the output.
Alright, I will add that as well in the next series.
Thank you!
K Jayatheerth <jayatheerthkulkarni2005@gmail.com>