Re: [GSoC][PATCH 4/4] repo: add path.commondir with absolute and relative suffix formatting
- From
Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
- Date
- Jun 1, 2026, 16:34 UTC
- Message-ID
- <11C531FB-2397-42AE-8F18-BF78BA779088@gmail.com>
- In-Reply-To
- <20260601151950.30686-5-jayatheerthkulkarni2005@gmail.com>
Show 10 quoted lines
> diff --git a/t/t1900-repo-info.sh b/t/t1900-repo-info.sh > index 7c7dfbb052..dd2706e1f7 100755 > --- a/t/t1900-repo-info.sh > +++ b/t/t1900-repo-info.sh > @@ -184,6 +184,7 @@ test_expect_success 'setup test repository layout for path fields' ' > mkdir -p test-repo/sub > ' > > +test_repo_info_path 'commondir' '../.git' > test_repo_info_path 'gitdir' '../.git'
I was thinking here, maybe you need to take a look at git-rev-parse's tests and check what are the corner cases.
For example, `git rev-parse --git-common-dir` documentation says:
--git-common-dir:
Show $GIT_COMMON_DIR if defined, else $GIT_DIRThis way, you should take a look on how git-rev-parse tests test those two branches (GIT_COMMON_DIR and GIT_DIR).