Re: [GSoC Patch v7 1/3] path: extract append_formatted_path() and use in rev-parse

From: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
Date: Jun 24, 2026, 03:49 UTC
Message-ID: <CA+rGoLd4MLp5RuLMCJ3R+UDNtpY0UdKnxokz=z=QCz6mpCE0Ag@mail.gmail.com>
In-Reply-To: <084ad4d0-d872-4c7f-94a8-ec2383c7a8ca@gmail.com>

Hey Phillip,

On Tue, Jun 23, 2026 at 9:27 PM Phillip Wood <phillip.wood123@gmail.com> wrote:

Show 19 quoted lines

>
> On 21/06/2026 06:55, K Jayatheerth wrote:
> > Path formatting logic in builtin/rev-parse.c writes directly to
> > stdout. Other builtins cannot reuse it.
> >
> > Extract this logic into append_formatted_path() in path.c and expose
> > a path_format enum in path.h.
> >
> > Convert rev-parse to use the new helper in the same step to validate
> > the API against existing tests and avoid introducing dead code.
>
> The new API looks good now, and so does the conversion of the existing
> code. I'm very happy with this version and don't have anything to add to
> Junio's comments
>
> Thanks
>
> Phillip
>

I have sent a v8 with Junio's feedback addressed. I wouldn't have a problem with either of the versions getting merged.

Both of them are good in their own ways.

Thank you,
- K Jayatheerth