Re: [GSoC PATCH v2 0/4] teach git repo info to handle path keys

From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Date: Jun 5, 2026, 17:35 UTC
Message-ID: <A67C8C8B-2600-41D2-9E61-0923BFDDD06B@gmail.com>
In-Reply-To: <20260605163012.181089-1-jayatheerthkulkarni2005@gmail.com>

Show 6 quoted lines

> * About lexicographical order: "Breaking" wasn't the right term
>  before, but I do believe keeping .absolute and .relative as
>  suffixes is a better choice. I prefer having the two choices
>  side-by-side grouped by entity, rather than a cluster of absolute
>  keys followed by relative ones. Open to hearing if the latter is
>  preferred!

I prefer `.(absolute|relative)` at the end. `path.gitdir.relative` means that we have a collection of paths, in those collections we have gitdir that can be relative or absolute, and we want the relative. `path.relative.gitdir` means that we have a collection of relative paths and from those we're picking gitdir. The first feels more natural.

> Thanks for this round of feedback guys, this has been fruitful!

Thanks again for your interest in improving `git repo info`! I'll review your patchset with more attention later.

PS: this is a nitpick, but it would be really helpful if you provide
a range-diff in the cover letter. Check the usage of `--range-diff`
in git-format-patch documentation (this flag also works for
git-send-email). Or, if you prefer, you can generate it by running
`git range-diff` and copying the output.