git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: prefer indent heuristic over compaction heuristic

From
Jacob Keller <jacob.keller@gmail.com>
Date
Dec 23, 2016, 22:23 UTC
Message-ID
<CA+P7+xrMFnW8NCySpMuWWnXBE30RwmOgr-0Xgjaa5i8eDPGGUw@mail.gmail.com>
In-Reply-To
<20161223222145.vkf6mjvs5t7ag3od@sigill.intra.peff.net>
On Fri, Dec 23, 2016 at 2:21 PM, Jeff King <peff@peff.net> wrote:
Show 16 quoted lines
> On Fri, Dec 23, 2016 at 01:17:03PM -0800, Junio C Hamano wrote:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>> > I guess both you and Michael are in favor of just removing compaction
>> > variant without any renames, so let me prepare a reroll and queue
>> > that instead.  We can flip the default perhaps one release later.
>>
>> -- >8 --
>> Subject: [PATCH] diff: retire "compaction" heuristics
>
> Looks good to me from a cursory read.
>
> Thanks.
>
> -Peff

Same. This is more obviously correct since we didn't have to change a bunch of references to INDENT_HEURISTIC. I agree that the name does not make sense now, but if our goal is to make it default with a disable option, I think that we shouldn't worry too much about the naming.

Thanks, Jake

Previous: Jeff KingNext: Michael Haggerty
Message 13 of 17 in “diff: prefer indent heuristic over compaction heuristic”
  1. diff: prefer indent heuristic over compaction heuristicJacob Keller, Dec 17, 2016
  2. Junio C HamanoDec 17, 2016
  3. Jacob KellerDec 17, 2016
  4. Junio C HamanoDec 22, 2016
  5. Jacob KellerDec 22, 2016
  6. Junio C HamanoDec 22, 2016
  7. Jeff KingDec 23, 2016
  8. Jacob KellerDec 23, 2016
  9. Jeff KingDec 23, 2016
  10. Junio C HamanoDec 23, 2016
  11. Junio C HamanoDec 23, 2016
  12. Jeff KingDec 23, 2016
  13. Jacob KellerDec 23, 2016
  14. Michael HaggertyDec 24, 2016
  15. Stefan BellerApr 27, 2017
  16. Jeff KingApr 28, 2017
  17. Martin LiškaApr 28, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.