git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: prefer indent heuristic over compaction heuristic

From
Jeff King <peff@peff.net>
Date
Apr 28, 2017, 08:11 UTC
Message-ID
<20170428081143.7ae7jflhrjukxcsh@sigill.intra.peff.net>
In-Reply-To
<CAGZ79kY2Yu=B+75D6DpNjdriAZnJ5pZSmYAUiYtF2aUK47_HPw@mail.gmail.com>
On Thu, Apr 27, 2017 at 02:17:55PM -0700, Stefan Beller wrote:
Show 9 quoted lines
> >> Retire "compaction", and keep "indent" as an experimental feature.
> >> The latter hopefully will be turned on by default in a future
> >> release, but that should be done as a separate step.
> 
> Maybe turning on this feature by default is the next step instead of
> adding them to bash competition or making them available in plumbing
> commands for the upcoming release.
> 
> Then in a later release we could even remove the knobs to turn it off.

Yeah, if we are going to proceed with making it the default, I'd rather do that than worry about adding frills that will eventually not matter.

We could take Marc's patch to move the config to git_diff_basic_config() as an interim step, though. It gives people an escape hatch if they find that they need to disable the feature for some plumbing command.

In that discussion, the only argument I could come up with against making it the default (or respecting it for plumbing) is that it may have an impact on patch-ids. I'm not sure I'm swayed by that, but I wanted to mention it to make sure we're deciding consciously not to care about it.

-Peff
Previous: Stefan BellerNext: Martin Liška
Message 16 of 17 in “diff: prefer indent heuristic over compaction heuristic”
  1. diff: prefer indent heuristic over compaction heuristicJacob Keller, Dec 17, 2016
  2. Junio C HamanoDec 17, 2016
  3. Jacob KellerDec 17, 2016
  4. Junio C HamanoDec 22, 2016
  5. Jacob KellerDec 22, 2016
  6. Junio C HamanoDec 22, 2016
  7. Jeff KingDec 23, 2016
  8. Jacob KellerDec 23, 2016
  9. Jeff KingDec 23, 2016
  10. Junio C HamanoDec 23, 2016
  11. Junio C HamanoDec 23, 2016
  12. Jeff KingDec 23, 2016
  13. Jacob KellerDec 23, 2016
  14. Michael HaggertyDec 24, 2016
  15. Stefan BellerApr 27, 2017
  16. Jeff KingApr 28, 2017
  17. Martin LiškaApr 28, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.