[PATCH] diff: prefer indent heuristic over compaction heuristic
- From
Jacob Keller <jacob.e.keller@intel.com>
- Date
- Dec 17, 2016, 00:54 UTC
- Message-ID
- <20161217005442.5866-1-jacob.e.keller@intel.com>
From: Jacob Keller <jacob.keller@gmail.com>
The current configuration code for enabling experimental heuristics prefers the last-set heuristic in the configuration. However, it is not necessarily easy to see what order the configuration will be read. This means that it is possible for a user to have accidentally enabled both heuristics, and end up only enabling the older compaction heuristic.
Modify the code so that we do not clear the other heuristic when we set each heuristic enabled. Then, during diff_setup() when we check the configuration, we will first check the newer indent heuristic. This ensures that we only enable the newer heuristic if both have been enabled.
Signed-off-by: Jacob Keller <jacob.keller@gmail.com> --- diff.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/diff.c b/diff.c index ec8728362dae..48a5b2797e3d 100644 --- a/diff.c +++ b/diff.c @@ -223,16 +223,10 @@ void init_diff_ui_defaults(void) int git_diff_heuristic_config(const char *var, const char *value, void *cb) { - if (!strcmp(var, "diff.indentheuristic")) { + if (!strcmp(var, "diff.indentheuristic")) diff_indent_heuristic = git_config_bool(var, value); - if (diff_indent_heuristic) - diff_compaction_heuristic = 0; - } - if (!strcmp(var, "diff.compactionheuristic")) { + if (!strcmp(var, "diff.compactionheuristic")) diff_compaction_heuristic = git_config_bool(var, value); - if (diff_compaction_heuristic) - diff_indent_heuristic = 0; - } return 0; }
-- 2.11.0.rc2.152.g4d04e67