Re: [PATCH] diff: prefer indent heuristic over compaction heuristic

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 23, 2016, 17:45 UTC
Message-ID: <xmqqh95uedzu.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161223161917.4a352c2wzerj5uyz@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> On Fri, Dec 23, 2016 at 12:12:13AM -0800, Jacob Keller wrote:
>
>> I actually would prefer that we just say "this is the default now" and
>> provide some knob "no-indent-heuristic" or "no-compaction-heuristic"
>> and go with that, I think, since I am pretty sure we're all in
>> agreement that the heuristic is an improvement in almost every case,
>> certainly all the ones we've found. It's at least not worse in any
>> case I've seen, and is usually better.
>> 
>> Thoughts? I don't have a super strong opinion about which name we went
>> with for the knob.
>
> Yes, I think we should also make --indent-heuristic the default. That's
> technically orthogonal to the name, but I agree the name becomes a lot
> less important when it is just on by default.

Yes, I agree that will be the endgame, but one step at the time, and also removing one of them is orthogonal that we would want to do sooner rather than later. So the step represented by the patch under discussion is the first one among the two towards the final state.

I guess both you and Michael are in favor of just removing compaction variant without any renames, so let me prepare a reroll and queue that instead. We can flip the default perhaps one release later.

Thanks.