Re: [PATCH 1/4] magic pathspec: add tentative ":/path/from/top/level" pathspec support
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Apr 7, 2011, 13:23 UTC
- Message-ID
- <BANLkTint7sGCg7_seu1-SWJC=_sKF-FKYw@mail.gmail.com>
- In-Reply-To
- <1302138996-10006-2-git-send-email-gitster@pobox.com>
On Thu, Apr 7, 2011 at 8:16 AM, Junio C Hamano <gitster@pobox.com> wrote:
> +The "magic signature" consists of an ASCII symbol that is not > +alphanumeric.
Except dot, as Michael pointed out in another email, so we can write ":/.foo" instead of ":/:.foo". I'm tempted to rule out wildcards as well (star, backslash, question mark and square brackets)
Also the patch does not catch this (ie. not die() on unrecognized signature).
-- Duy