Re: [PATCH 1/4] magic pathspec: add tentative ":/path/from/top/level" pathspec support

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Apr 8, 2011, 12:00 UTC
Message-ID: <BANLkTi=YK-4TOxoD1qR8TO4SymLK6sPnQA@mail.gmail.com>
In-Reply-To: <7vd3kyf327.fsf@alter.siamese.dyndns.org>

On Thu, Apr 7, 2011 at 11:18 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>
>> Also the patch does not catch this (ie. not die() on unrecognized signature).
>
> Of course it doesn't.
>
> I didn't say "everything that is not alphanumeric is magic". I only said
> "all the magic are not alphanumeric".  Notice the difference.
>
>
> This is so that you can say ":/.gitignore" and do not have to say
> ":/:.gitignore".

But then, say people have a file named @foo at top dir. They can write ":/@foo" to address the file. Some time later we decide to use '@' as magic, how can we re-train user's fingers?

> I am also tempted to special case a ':' followed by a zero magic as if it
> specifies the top magic, e.g. ":Makefile" is the same as ":(top)Makefile",
> aka ":/Makefile".  It is not in the published code, but the short-cut
> would help ":.gitignore".

If you're not too tempted to do it, then reserve the case (ie. die()). Although I quite like it, one less keystroke for me.

-- 
Duy