From: Nguyen Thai Ngoc Duy Date: Thu, 07 Apr 2011 13:23:21 GMT Subject: Re: [PATCH 1/4] magic pathspec: add tentative ":/path/from/top/level" pathspec support Message-ID: In-Reply-To: <1302138996-10006-2-git-send-email-gitster@pobox.com> On Thu, Apr 7, 2011 at 8:16 AM, Junio C Hamano wrote: > +The "magic signature" consists of an ASCII symbol that is not > +alphanumeric. Except dot, as Michael pointed out in another email, so we can write ":/.foo" instead of ":/:.foo". I'm tempted to rule out wildcards as well (star, backslash, question mark and square brackets) Also the patch does not catch this (ie. not die() on unrecognized signature). -- Duy