Re: [PATCH 2/4] add -u: get rid of "treewideupdate" configuration
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 9, 2011, 21:38 UTC
- Message-ID
- <7vk4f3yuj9.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <BANLkTik32jvmJOtFRB9+vCnd_NWC2ft1fA@mail.gmail.com>
Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
Show 11 quoted lines
> On Sat, Apr 9, 2011 at 11:58 AM, Nguyen Thai Ngoc Duy <pclouds@gmail.com> wrote: >> On Sat, Apr 9, 2011 at 6:18 AM, Junio C Hamano <gitster@pobox.com> wrote: >>> Also make ':' without anything else to mean "there is no pathspec". This >>> would allow differences between "git log" and "git log ." run from the top >>> level of the working tree (the latter simplifies no-op commits away from >>> the history) to be expressed from a subdirectory by saying "git log :". >> >> The intention is good, but reality may need more work. > > Wait, what if I say "git grep -- : foo : bar"? I take it we should > reject on this case?
The patch probably would stuff NULL, "foo", NULL, "bar" in the array, and the first NULL would make the caller turn the array itself into NULL; it is a user error I didn't have to bother while the topic is still in a PoC stage.