Re: [PATCH 1/4] magic pathspec: add tentative ":/path/from/top/level" pathspec support
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Apr 8, 2011, 17:02 UTC
- Message-ID
- <BANLkTimTm3L62J-bErmxYNE0=CRChvaKQQ@mail.gmail.com>
- In-Reply-To
- <7vpqow4s3f.fsf@alter.siamese.dyndns.org>
On Fri, Apr 8, 2011 at 11:37 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Off the top of my head, we should exclude "." (period -- dot-files are > common), "_" (underscore), and possibly "+" (plus) and "=" (equal), as I > saw these used to start filenames, but the latter two are rather rare and > I don't mind requiring the terminating colon after the magic signature.
Totally agree on dot and underscore. I don't really care the other two. While '*' is not actually part of path name, '*.[ch]' is commonly used, and I usually have to quote once to avoid bash expansion already. So put asterisk in exclude list too, to avoid another quote?
-- Duy