git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Git Rebase blows away GIT_AUTHOR_NAME

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Jan 17, 2011, 22:29 UTC
Message-ID
<AANLkTinyteSHE6DpBi6mXLW7HpgXkEZL8HBeSuFyw+v2@mail.gmail.com>
In-Reply-To
<20110117222128.GA30869@sigill.intra.peff.net>
On Mon, Jan 17, 2011 at 11:21 PM, Jeff King <peff@peff.net> wrote:
Show 17 quoted lines
> On Fri, Jan 14, 2011 at 11:21:45AM -0500, Jeff King wrote:
>
>> So we should probably do one or both of:
>>
>>   1. Make an --allow-any-name option to mailinfo, and use it when we
>>      invoke mailinfo internally for rebasing. That still doesn't solve
>>      the emailed patch problem, but at least keeps purely internal
>>      operations sane.
>
> So I wrote up a nice tidy patch series with mailinfo changes and tests,
> and then am/rebase changes and tests on top of that. And guess what I
> noticed? My rebase tests didn't actually fail with stock git.
>
> I bisected to 43c2325 (am: use get_author_ident_from_commit instead of
> mailinfo when rebasing, 2010-06-16), which was written to handle exactly
> this sort of thing.
>
Heh, same story bro :(

Just for reference, my patch can be found at http://repo.or.cz/w/git/kusma.git work/rebase-keep-name

Previous: Jeff KingNext: JT Olds
Message 23 of 30 in “Git Rebase blows away GIT_AUTHOR_NAME”
  1. JT OldsJan 12, 2011
  2. Jeff KingJan 12, 2011
  3. JT OldsJan 13, 2011
  4. JT OldsJan 13, 2011
  5. Erik Faye-LundJan 13, 2011
  6. JT OldsJan 13, 2011
  7. Erik Faye-LundJan 13, 2011
  8. Tor ArntsenJan 14, 2011
  9. Erik Faye-LundJan 14, 2011
  10. Tor ArntsenJan 14, 2011
  11. Erik Faye-LundJan 14, 2011
  12. JT OldsJan 14, 2011
  13. Linus TorvaldsJan 14, 2011
  14. Erik Faye-LundJan 14, 2011
  15. Jeff KingJan 14, 2011
  16. Erik Faye-LundJan 14, 2011
  17. Jeff KingJan 14, 2011
  18. Jay SoffianJan 14, 2011
  19. Junio C HamanoJan 14, 2011
  20. Jeff KingJan 14, 2011
  21. Junio C HamanoJan 14, 2011
  22. Jeff KingJan 17, 2011
  23. Erik Faye-LundJan 17, 2011
  24. JT OldsJan 18, 2011
  25. Jay SoffianJan 19, 2011
  26. Tor ArntsenJan 14, 2011
  27. Erik Faye-LundJan 14, 2011
  28. Linus TorvaldsJan 14, 2011
  29. Erik Faye-LundJan 14, 2011
  30. Jeff KingJan 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.