Re: Git Rebase blows away GIT_AUTHOR_NAME

From: JT Olds <jtolds@xnet5.com>
Date: Jan 18, 2011, 03:55 UTC
Message-ID: <AANLkTinY1Wcirxi2bRUv+GuTG9eWczd-T1o0Mmx8VFdA@mail.gmail.com>
In-Reply-To: <20110117222128.GA30869@sigill.intra.peff.net>

On Mon, Jan 17, 2011 at 3:21 PM, Jeff King <peff@peff.net> wrote:

Show 26 quoted lines

> On Fri, Jan 14, 2011 at 11:21:45AM -0500, Jeff King wrote:
>
>> So we should probably do one or both of:
>>
>>   1. Make an --allow-any-name option to mailinfo, and use it when we
>>      invoke mailinfo internally for rebasing. That still doesn't solve
>>      the emailed patch problem, but at least keeps purely internal
>>      operations sane.
>
> So I wrote up a nice tidy patch series with mailinfo changes and tests,
> and then am/rebase changes and tests on top of that. And guess what I
> noticed? My rebase tests didn't actually fail with stock git.
>
> I bisected to 43c2325 (am: use get_author_ident_from_commit instead of
> mailinfo when rebasing, 2010-06-16), which was written to handle exactly
> this sort of thing.
>
> That commit made it into v1.7.2. JT, which version of git are you
> running? Do you still see any problems with v1.7.2 and above? I can't
> replicate your issue with more recent versions.
>
> So unless we want to do any sort of commit-time warning, I don't think
> there is anything left to be done on this topic.
>
> -Peff
>

Oh ho! No, I am running 1.7.1. I was so pleased to find out what the root of the problem was, though, that I did go and add my last name and haven't had any trouble since.

Thanks for all your help everyone.

-JT