Re: Git Rebase blows away GIT_AUTHOR_NAME
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 14, 2011, 18:28 UTC
- Message-ID
- <7vhbdbnxud.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20110114162144.GA867@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 14 quoted lines
> So we should probably do one or both of: > > 1. Make an --allow-any-name option to mailinfo, and use it when we > invoke mailinfo internally for rebasing. That still doesn't solve > the emailed patch problem, but at least keeps purely internal > operations sane. > > 2. Bump the check up to git-commit time, which is the best place to > catch and tell somebody that their name is too short, because they > can actually fix it. > > Even if we dropped the check now, option (2) is still useful, because > you have no idea which version of git the other end will use to apply > your patch.
I am perfectly Ok with making the check looser in "am" when $rebasing is in effect. Wouldn't that solve the issue?