git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Git Rebase blows away GIT_AUTHOR_NAME

From
Jeff King <peff@peff.net>
Date
Jan 14, 2011, 16:33 UTC
Message-ID
<20110114163333.GA1230@sigill.intra.peff.net>
In-Reply-To
<AANLkTimcQq++CLv66AyTve+PiXBhYdUPk2epCyOXX1c0@mail.gmail.com>
On Fri, Jan 14, 2011 at 05:30:51PM +0100, Erik Faye-Lund wrote:
Show 8 quoted lines
> >  2. Bump the check up to git-commit time, which is the best place to
> >     catch and tell somebody that their name is too short, because they
> >     can actually fix it.
> >
> 
> The problem with (2) is that git-am uses git-commit-tree rather than
> git-commit. But I do think that adding the same checks to git-commit
> would make sense. Unless we decide to remove the checks, that is...

Yeah, I didn't say it very clearly, but I meant to factor the check out and use it also in git-commit (probably as a warning, the same way we do with other ident verification in print_summary().

Even if we remove the check, it may still be worthwhile to say "Just so you know, older versions of git may mangle the name you have chosen".

-Peff
Previous: Erik Faye-LundNext: Jay Soffian
Message 17 of 30 in “Git Rebase blows away GIT_AUTHOR_NAME”
  1. JT OldsJan 12, 2011
  2. Jeff KingJan 12, 2011
  3. JT OldsJan 13, 2011
  4. JT OldsJan 13, 2011
  5. Erik Faye-LundJan 13, 2011
  6. JT OldsJan 13, 2011
  7. Erik Faye-LundJan 13, 2011
  8. Tor ArntsenJan 14, 2011
  9. Erik Faye-LundJan 14, 2011
  10. Tor ArntsenJan 14, 2011
  11. Erik Faye-LundJan 14, 2011
  12. JT OldsJan 14, 2011
  13. Linus TorvaldsJan 14, 2011
  14. Erik Faye-LundJan 14, 2011
  15. Jeff KingJan 14, 2011
  16. Erik Faye-LundJan 14, 2011
  17. Jeff KingJan 14, 2011
  18. Jay SoffianJan 14, 2011
  19. Junio C HamanoJan 14, 2011
  20. Jeff KingJan 14, 2011
  21. Junio C HamanoJan 14, 2011
  22. Jeff KingJan 17, 2011
  23. Erik Faye-LundJan 17, 2011
  24. JT OldsJan 18, 2011
  25. Jay SoffianJan 19, 2011
  26. Tor ArntsenJan 14, 2011
  27. Erik Faye-LundJan 14, 2011
  28. Linus TorvaldsJan 14, 2011
  29. Erik Faye-LundJan 14, 2011
  30. Jeff KingJan 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.