From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Mon, 17 Jan 2011 22:29:53 GMT
Subject: Re: Git Rebase blows away GIT_AUTHOR_NAME
Message-ID: <AANLkTinyteSHE6DpBi6mXLW7HpgXkEZL8HBeSuFyw+v2@mail.gmail.com>
In-Reply-To: <20110117222128.GA30869@sigill.intra.peff.net>

On Mon, Jan 17, 2011 at 11:21 PM, Jeff King <peff@peff.net> wrote:
> On Fri, Jan 14, 2011 at 11:21:45AM -0500, Jeff King wrote:
>
>> So we should probably do one or both of:
>>
>>   1. Make an --allow-any-name option to mailinfo, and use it when we
>>      invoke mailinfo internally for rebasing. That still doesn't solve
>>      the emailed patch problem, but at least keeps purely internal
>>      operations sane.
>
> So I wrote up a nice tidy patch series with mailinfo changes and tests,
> and then am/rebase changes and tests on top of that. And guess what I
> noticed? My rebase tests didn't actually fail with stock git.
>
> I bisected to 43c2325 (am: use get_author_ident_from_commit instead of
> mailinfo when rebasing, 2010-06-16), which was written to handle exactly
> this sort of thing.
>

Heh, same story bro :(

Just for reference, my patch can be found at
http://repo.or.cz/w/git/kusma.git work/rebase-keep-name