git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] tests: make test_must_fail more verbose

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Sep 1, 2010, 10:55 UTC
Message-ID
<AANLkTinU7nV09NMvsZ+u9JCzeDsLqw3gS-7Y=i0Eqk_X@mail.gmail.com>
In-Reply-To
<AANLkTi=aGdLj4vRKs8dR64JO=c8eC3SHj0_hkh6Wutaw@mail.gmail.com>
On Wed, Sep 1, 2010 at 03:37, Jon Seymour <jon.seymour@gmail.com> wrote:
Show 15 quoted lines
> On Wed, Sep 1, 2010 at 1:56 AM, Jeff King <peff@peff.net> wrote:
>> Because test_must_fail fails when a command succeeds, the
>> command frequently does not produce any output (since, after
>> all, it thought it was succeeding). So let's have
>> test_must_fail itself report that a problem occurred.
>>
>> Signed-off-by: Jeff King <peff@peff.net>
>
> Jeff,
>
> Nice fix - thank you!
>
> It is nice to see that my initial sloppiness inspired a thoughtful
> remediation. I'll try not to rely of gitters being always so helpful
> :-)

FWIW I plan to make this sort of thing better for everything when I pick up my "WIP: Report intra-test progress with TAP subtests" series again. I.e. use >&5 instead of >&2 and turn this sort of thing into subtests.

But if you're interested in picking up someone else's slack it could use some help :) I don't know when I'll get around to fixing it up: http://github.com/avar/git/commit/e2ac35a8e49ceec98ca512bf106ce04c93c84b5c

Previous: Jon SeymourNext: Jeff King
Message 10 of 17 in “fix quotes in maint-reflog-beyond-horizon and detached-stash”
  1. 0/2 fix quotes in maint-reflog-beyond-horizon and detached-stashJon Seymour, Aug 31, 2010
  2. 1/2 maint-reflog-beyond-horizon: fix broken test_must_fail callsJon Seymour, Aug 31, 2010
  3. 2/2 detached-stash: fix broken test_must_fail callsJon Seymour, Aug 31, 2010
  4. Jeff KingAug 31, 2010
  5. 1/2 tests: make test_must_fail more verboseJeff King, Aug 31, 2010
  6. Jonathan NiederAug 31, 2010
  7. Jeff KingAug 31, 2010
  8. Jonathan NiederAug 31, 2010
  9. Jon SeymourSep 1, 2010
  10. Ævar Arnfjörð BjarmasonSep 1, 2010
  11. 2/2 tests: make test_must_fail fail on missing commandsJeff King, Aug 31, 2010
  12. Junio C HamanoAug 31, 2010
  13. Jeff KingAug 31, 2010
  14. Jonathan NiederAug 31, 2010
  15. Jeff KingAug 31, 2010
  16. Ævar Arnfjörð BjarmasonAug 31, 2010
  17. Junio C HamanoAug 31, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.