Re: [PATCH 2/2] tests: make test_must_fail fail on missing commands

From: Jeff King <peff@peff.net>
Date: Aug 31, 2010, 17:25 UTC
Message-ID: <20100831172528.GA15020@sigill.intra.peff.net>
In-Reply-To: <7v7hj6d8im.fsf@alter.siamese.dyndns.org>

On Tue, Aug 31, 2010 at 09:58:09AM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> > +	elif test $exit_code = 127; then
> > +		echo >&2 "test_must_fail: command not found: $*"
> > +		return 1
> >  	fi
> 
> Hmm.  One worry is that if we ever exit(127) ourselves this would be
> confused, but hopefully we are not that clueless.

Yeah, I considered that but dismissed it. I don't think we are that clueless, and even if we were, then I think test_must_fail is doing a good thing by pointing it out to us.

-Peff