git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] maint-reflog-beyond-horizon: fix broken test_must_fail calls

From
Jon Seymour <jon.seymour@gmail.com>
Date
Aug 31, 2010, 14:49 UTC
Message-ID
<1283266160-11665-2-git-send-email-jon.seymour@gmail.com>
In-Reply-To
<1283266160-11665-1-git-send-email-jon.seymour@gmail.com>

Some tests in maint-reflog-beyond-horizon are calling test_must_fail in such a way that the arguments to test_must_fail do, indeed, fail but not in the manner expected by the test.

This patch removes the unnecessary and unhelpful double quotes.
Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
---
 t/t1503-rev-parse-verify.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t1503-rev-parse-verify.sh b/t/t1503-rev-parse-verify.sh
index 61092f7..100f857 100755
--- a/t/t1503-rev-parse-verify.sh
+++ b/t/t1503-rev-parse-verify.sh
@@ -111,8 +111,8 @@ test_expect_success 'master@{n} for various n' '
 	git rev-parse --verify master@{0} &&
 	git rev-parse --verify master@{1} &&
 	git rev-parse --verify master@{$Nm1} &&
-	test_must_fail "git rev-parse --verify master@{$N}" &&
-	test_must_fail "git rev-parse --verify master@{$Np1}"
+	test_must_fail git rev-parse --verify master@{$N} &&
+	test_must_fail git rev-parse --verify master@{$Np1}
 '
 
 test_done
-- 
1.7.2.80.g22196.dirty
Previous: Jon SeymourNext: Jon Seymour
Message 2 of 17 in “fix quotes in maint-reflog-beyond-horizon and detached-stash”
  1. 0/2 fix quotes in maint-reflog-beyond-horizon and detached-stashJon Seymour, Aug 31, 2010
  2. 1/2 maint-reflog-beyond-horizon: fix broken test_must_fail callsJon Seymour, Aug 31, 2010
  3. 2/2 detached-stash: fix broken test_must_fail callsJon Seymour, Aug 31, 2010
  4. Jeff KingAug 31, 2010
  5. 1/2 tests: make test_must_fail more verboseJeff King, Aug 31, 2010
  6. Jonathan NiederAug 31, 2010
  7. Jeff KingAug 31, 2010
  8. Jonathan NiederAug 31, 2010
  9. Jon SeymourSep 1, 2010
  10. Ævar Arnfjörð BjarmasonSep 1, 2010
  11. 2/2 tests: make test_must_fail fail on missing commandsJeff King, Aug 31, 2010
  12. Junio C HamanoAug 31, 2010
  13. Jeff KingAug 31, 2010
  14. Jonathan NiederAug 31, 2010
  15. Jeff KingAug 31, 2010
  16. Ævar Arnfjörð BjarmasonAug 31, 2010
  17. Junio C HamanoAug 31, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.