git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] tests: make test_must_fail fail on missing commands

From
Jeff King <peff@peff.net>
Date
Aug 31, 2010, 18:08 UTC
Message-ID
<20100831180847.GC15020@sigill.intra.peff.net>
In-Reply-To
<20100831172657.GP2315@burratino>
On Tue, Aug 31, 2010 at 12:26:57PM -0500, Jonathan Nieder wrote:
Show 6 quoted lines
> Jeff King wrote:
> 
> > The point of it is to run a command that produces failure. A
> > missing command is more likely an error in the test script
> 
> Makes sense.  Here's the corresponding change for test_might_fail.

I think this is probably worth doing. Unless somebody is doing something silly like:

  test_might_fail command_that_might_exist

But that seems a pretty contrived scenario (I am imagining something like "call sync now, but if we don't have it, don't fail". But in the test scripts that seems unlikely).

-Peff
Previous: Jonathan NiederNext: Ævar Arnfjörð Bjarmason
Message 15 of 17 in “fix quotes in maint-reflog-beyond-horizon and detached-stash”
  1. 0/2 fix quotes in maint-reflog-beyond-horizon and detached-stashJon Seymour, Aug 31, 2010
  2. 1/2 maint-reflog-beyond-horizon: fix broken test_must_fail callsJon Seymour, Aug 31, 2010
  3. 2/2 detached-stash: fix broken test_must_fail callsJon Seymour, Aug 31, 2010
  4. Jeff KingAug 31, 2010
  5. 1/2 tests: make test_must_fail more verboseJeff King, Aug 31, 2010
  6. Jonathan NiederAug 31, 2010
  7. Jeff KingAug 31, 2010
  8. Jonathan NiederAug 31, 2010
  9. Jon SeymourSep 1, 2010
  10. Ævar Arnfjörð BjarmasonSep 1, 2010
  11. 2/2 tests: make test_must_fail fail on missing commandsJeff King, Aug 31, 2010
  12. Junio C HamanoAug 31, 2010
  13. Jeff KingAug 31, 2010
  14. Jonathan NiederAug 31, 2010
  15. Jeff KingAug 31, 2010
  16. Ævar Arnfjörð BjarmasonAug 31, 2010
  17. Junio C HamanoAug 31, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.