Re: [PATCH v4 64/73] gettextize: git-describe basic messages
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Feb 26, 2011, 13:16 UTC
- Message-ID
- <AANLkTimui6T5b8w1wXgVsNu5y0OA9S_UMofs2K=Tx-ZW@mail.gmail.com>
- In-Reply-To
- <201102261055.58539.jnareb@gmail.com>
On Sat, Feb 26, 2011 at 10:55, Jakub Narebski <jnareb@gmail.com> wrote:
Show 14 quoted lines
> On Wed, 23 Feb 2011, Ævar Arnfjörð Bjarmason wrote:
>
>> if (strcmp(n->tag->tag, all ? n->path + 5 : n->path))
>> - warning("tag '%s' is really '%s' here", n->tag->tag, n->path);
>> + warning(_("tag '%s' is really '%s' here"), n->tag->tag, n->path);
>> n->name_checked = 1;
>> }
>
> Don't we need to use order notation to be able to change order of those
> two parameters, i.e. use
>
> + warning(_("tag '%1$s' is really '%2$s' here"), n->tag->tag, n->path);
>
> Perhaps also some comment for translators describing placeholders?No, the original string doesn't need those. But the translators can insert them in their PO file if they want.