Re: [PATCH 02/15] tests: add GETTEXT_POISON to simulate unfriendly translator
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Feb 21, 2011, 12:41 UTC
- Message-ID
- <AANLkTikCvaWOQaE8628RVeAsdizVBr3vHawjwKdVJK5N@mail.gmail.com>
- In-Reply-To
- <20110221101352.GC32137@elie>
On Mon, Feb 21, 2011 at 11:13, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 5 quoted lines
> static inline FORMAT_PRESERVING(1) const char *_(const char *msgid)
> {
> - return msgid;
> + return use_poison() ? "Malkovich" : msgid;
> }Why did you change this from "# GETTEXT POISON #" to "Malkovich"?
The reason it started with a "#" is because many rebase tests were broken otherwise.
The reason it was in all caps was so that when I run the tests in debug mode it's really easy to see at a glance if I'm encountering these strings.
Do those tests still pass with this new string, and is there any reason to change this?