Re: [PATCH v4 64/73] gettextize: git-describe basic messages
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Feb 26, 2011, 09:55 UTC
- Message-ID
- <201102261055.58539.jnareb@gmail.com>
- In-Reply-To
- <1298418152-27789-65-git-send-email-avarab@gmail.com>
On Wed, 23 Feb 2011, Ævar Arnfjörð Bjarmason wrote:
Show 5 quoted lines
> if (strcmp(n->tag->tag, all ? n->path + 5 : n->path))
> - warning("tag '%s' is really '%s' here", n->tag->tag, n->path);
> + warning(_("tag '%s' is really '%s' here"), n->tag->tag, n->path);
> n->name_checked = 1;
> }Don't we need to use order notation to be able to change order of those two parameters, i.e. use
+ warning(_("tag '%1$s' is really '%2$s' here"), n->tag->tag, n->path);Perhaps also some comment for translators describing placeholders?
-- Jakub Narebski Poland