Re: [PATCH] commit: error out for missing commit message template
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 25, 2011, 20:14 UTC
- Message-ID
- <7v1v2van3e.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20110225090756.GI23037@elie>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 12 quoted lines
>> --- a/builtin/commit.c
>> +++ b/builtin/commit.c
>> @@ -725,15 +725,15 @@ static int prepare_to_commit(const char *index_file, const char *prefix,
> [...]
>> - "%s"
>> - "# Author: %s\n",
>> + _("%s"
>> + "# Author: %s\n"),
>
> The above change causes the commit message template to be nonempty,
> excluding comments, so bare "git commit" succeeds, exposing this
> longstanding bug.Thanks; using "#" at the beginning of poison message sometimes has its uses ;-)
Will queue.