Re: [PATCH] t/: work around one-shot variable assignment with test_must_fail
On Tue, Jul 20, 2010 at 23:44, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 12 quoted lines
> On Tue, Jul 20, 2010 at 21:55, Brandon Casey <casey@nrlssc.navy.mil> wrote:
>
>> - test_must_fail PAGER= git reflog show delta &&
>> + (
>> + PAGER= &&
>> + export PAGER &&
>> + test_must_fail git reflog show delta
>> + ) &&
>
> You must use "export PAGER;", not "export PAGER &&". export doesn't
> return zero on all systems when exporting, see previous changes in
> this regard in t/.
Actually, see the t/README docs which explicitly mention this. Yay docs.