Re: [PATCH] t/t3700: convert two uses of negation operator '!' to use test_must_fail

From: Jared Hance <jaredhance@gmail.com>
Date: Jul 20, 2010, 16:38 UTC
Message-ID: <20100720163822.GA8492@localhost.localdomain>
In-Reply-To: <fVE942wHC3SFihkQG8AthPTKiTZtYJ9zmR2TT7F5OlkGD4IA9xPcMA@cipher.nrlssc.navy.mil>

On Tue, Jul 20, 2010 at 11:32:33AM -0500, Brandon Casey wrote:

Show 13 quoted lines

> I think you have misunderstood the explanation of test_must_fail.  The
> paragraph you quoted actually recommends using test_must_fail instead
> of "! <git-command>".
> 
> It says:
> 
>    Use this instead of "! <git-command>" to fail when git commands
>    segfault.
> 
> Or with a slight rewording:
> 
>    Use test_must_fail instead of "! <git-command>" since test_must_fail
>    will fail when <git-command> segfaults.

I think the wording of description of test_must_fail is slightly ambiguous. I read it to mean that:

    Use test_must_fail only when you are testing to see if git will
    segfault.

Rather than:
    
    Use test_must_fail to be safe from git segfaults.

Perhaps the description should be updated to be a bit more clear?