Re: [PATCH] Convert "! git" to "test_must_fail" git.

From: Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil>
Date: Jul 20, 2010, 19:59 UTC
Message-ID: <7f2yYiHON5cy37krPeX7WXFeoN42YYjGc04eHV92atxS4vuERQ3MCA@cipher.nrlssc.navy.mil>
In-Reply-To: <20100720194807.GA2259@burratino>

On 07/20/2010 02:48 PM, Jonathan Nieder wrote:

Show 22 quoted lines

> Brandon Casey wrote:
> 
>> I believe the '!' negates the
>> result of the entire statement, but test_must_fail only
>> operates on the arguments preceding the '|'.
> 
> Right.  For example:
> 
>> On 07/20/2010 02:09 PM, Jared Hance wrote:
> 
> [...]
>>> +++ b/t/t7810-grep.sh
>>> @@ -134,7 +134,7 @@ do
>>>  	'
>>>  
>>>  	test_expect_success "grep -c $L (no /dev/null)" '
>>> -		! git grep -c test $H | grep /dev/null
>>> +		test_must_fail git grep -c test $H | grep /dev/null
> 
> should be
> 
> 	git grep -c test $H | ! grep /dev/null

I seem to recall that that doesn't work either.

   $ /bin/bash -c 'echo foo | ! grep bar && echo success || echo failure'
   /bin/bash: -c: line 0: syntax error near unexpected token `!'
   /bin/bash: -c: line 0: `echo foo | ! grep bar && echo success || echo failure'

-brandon