Re: [PATCH] t/: work around one-shot variable assignment with test_must_fail
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jul 21, 2010, 00:09 UTC
- Message-ID
- <AANLkTik0gKFfDCmcLZnn4WFCFY3Lb5zRgrzKLAgD5qH6@mail.gmail.com>
- In-Reply-To
- <20100721000101.GB4282@burratino>
On Wed, Jul 21, 2010 at 00:01, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 22 quoted lines
> Ævar Arnfjörð Bjarmason wrote: > >> You must use "export PAGER;", not "export PAGER &&". export doesn't >> return zero on all systems when exporting, see previous changes in >> this regard in t/. > > Nope. Sorry I missed this before. > > diff --git a/t/README b/t/README > index b906ceb..f81998b 100644 > --- a/t/README > +++ b/t/README > @@ -259,11 +259,11 @@ Do: > test ... > > That way all of the commands in your tests will succeed or fail. If > - you must ignore the return value of something (e.g. the return > - value of export is unportable) it's best to indicate so explicitly > - with a semicolon: > + you must ignore the return value of something (e.g., the return > + after unsetting a variable that was already unset is unportable) it's > + best to indicate so explicitly with a semicolon:
We should have examples for both export and unset, but the prose should mention both IMO