Re: [PATCH] help.c: Pull cmd_version out of this file.
On Wed, Sep 1, 2010 at 10:04 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
> Thiago Farina <tfransosi@gmail.com> writes:
>
>>>risk causing broken builds?
>> Hum, how such trivial change can cause that?
>
> Imagine if we had this in help.c:
>
Show 10 quoted lines
> int cmd_version(int argc, const char **argv, const char *prefix)
> {
> printf("git version %s\n", GIT_VERSION);
> return 0;
> }
>
> which were compiled with this rule in Makefile:
>
> help.o: help.c GIT-VERSION-FILE
>> and then you moved the function to a new file without touching the
> dependency.
That would be a mistake no?
> Especially because the change is trivial (just moving a
> function from here to there), you don't immediately notice the broken
> dependency.
>
As far as I know that does not go unnoticed.
> I just spent 15+ minutes explaining this to you (and another 10+ minutes
> checking that the above is _not_ the actual case before giving the same
> explanation to you last night).
Thanks for being so careful.
> Now is this still a trivial change that
> costs nothing?
>
Why you impose so much obstacles to a trivial change like this?
Show 5 quoted lines
>>>What did we gain through this exercise? Did we fix any real problem?
>> All patches should just fix real problems?
>
> There is a "cost vs benefit" ratio you need to consider.
>
Thiago Farina <tfransosi@gmail.com>