Re: [PATCH] help.c: Pull cmd_version out of this file.

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 2, 2010, 04:35 UTC
Message-ID: <20100902043500.GF29713@burratino>
In-Reply-To: <AANLkTinHJHzcoFFjv-TaQ+DYVyqn46fqA802m8Lq5anp@mail.gmail.com>

Thiago Farina wrote:

> All patches should just fix real problems?

Yes.

> I think it just makes more sense, since *all* other commands are in
> builtin/ and it's own files.

I was careless before and was not even thinking about

 BUILT_INS += $(patsubst builtin/%.o,git-%$X,$(BUILTIN_OBJS))

Sorry.

With that line in mind, what Junio wrote in the "what's cooking" message makes a lot of sense. A good direction to go in long term might be to freeze the list of built-ins installed to $gitexecdir in some clean way and avoid adding new ones.

Would you be interested in working on that? That would solve a problem (turning back the tide of scripts that use git- commands, without breaking compatibility) that some people are interested in. The hardest part would probably be to make sure commands like "git help version" work properly.