Re: [PATCH] help.c: Pull cmd_version out of this file.

From: Thiago Farina <tfransosi@gmail.com>
Date: Sep 1, 2010, 06:22 UTC
Message-ID: <AANLkTinHJHzcoFFjv-TaQ+DYVyqn46fqA802m8Lq5anp@mail.gmail.com>
In-Reply-To: <7v1v9e803a.fsf@alter.siamese.dyndns.org>

On Wed, Sep 1, 2010 at 3:11 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 5 quoted lines

> If the patch were to also move git_version_string[] from git.c to this new
> file, whose sole purpose will be to give the version information, then it
> might be worth it, as we would need to recompile a file with only 10 lines
> instead of git.c with 570 lines, but what the patch does is not even that.
>

It doesn't do that, but if you suggest that, I can fix it up later and resend it.

>risk causing broken builds?

Hum, how such trivial change can cause that?

>What did we gain through this exercise?  Did we fix any real problem?

All patches should just fix real problems?

I think it just makes more sense, since *all* other commands are in builtin/ and it's own files.