Re: [PATCH] help.c: Pull cmd_version out of this file.

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 1, 2010, 06:11 UTC
Message-ID: <7v1v9e803a.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTimDjRz=JmiVn+ybQ5ewaj=7N5tp48fUArD5vG_H@mail.gmail.com>

Thiago Farina <tfransosi@gmail.com> writes:

Show 12 quoted lines

> On Sun, Aug 29, 2010 at 11:40 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Jonathan Nieder wrote:
>>> Thiago Farina wrote:
>>>
>>>> Promote cmd_version to a builtin, by moving it to its own file
>>>> in builtin/version.c
>> [...]
>> So for what it's worth,
>>
>> Acked-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Ping Junio.

If the patch were to also move git_version_string[] from git.c to this new file, whose sole purpose will be to give the version information, then it might be worth it, as we would need to recompile a file with only 10 lines instead of git.c with 570 lines, but what the patch does is not even that.

Not that I would be happy to see such a change that affects dependency and risk causing broken builds this late in the cycle, though.

I ended up spending 10+ minutes re-checking how the dependency between the version string and the resulting binaries work. The patch probably would cause "git clean" to report a new unignored file, too.

What did we gain through this exercise?  Did we fix any real problem?

"git grep" sees directory boundaries through just fine, and I do not find Jonathan's explanation very satisfactory.

		Junio, who gets a lot more grumpy than necessary at night...