From: Thiago Farina Date: Thu, 02 Sep 2010 01:16:53 GMT Subject: Re: [PATCH] help.c: Pull cmd_version out of this file. Message-ID: In-Reply-To: <7v39tt552b.fsf@alter.siamese.dyndns.org> On Wed, Sep 1, 2010 at 10:04 PM, Junio C Hamano wrote: > Thiago Farina writes: > >>>risk causing broken builds? >> Hum, how such trivial change can cause that? > > Imagine if we had this in help.c: > But we don't have. >        int cmd_version(int argc, const char **argv, const char *prefix) >        { >                printf("git version %s\n", GIT_VERSION); >                return 0; >        } > > which were compiled with this rule in Makefile: > >        help.o: help.c GIT-VERSION-FILE > But it's not. > and then you moved the function to a new file without touching the > dependency. That would be a mistake no? >  Especially because the change is trivial (just moving a > function from here to there), you don't immediately notice the broken > dependency. > As far as I know that does not go unnoticed. > I just spent 15+ minutes explaining this to you (and another 10+ minutes > checking that the above is _not_ the actual case before giving the same > explanation to you last night). Thanks for being so careful. >  Now is this still a trivial change that > costs nothing? > Why you impose so much obstacles to a trivial change like this? >>>What did we gain through this exercise?  Did we fix any real problem? >> All patches should just fix real problems? > > There is a "cost vs benefit" ratio you need to consider. > Thanks.