git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] rebase -i: add run command to launch a shell command

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jul 31, 2010, 13:56 UTC
Message-ID
<AANLkTikMW=ueQXfjpXk8G2FLRN55j1aJsnNz2w19BmkH@mail.gmail.com>
In-Reply-To
<vpqd3u53sd2.fsf@bauges.imag.fr>

On Fri, Jul 30, 2010 at 15:24, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 9 quoted lines
> Marc Branchaud <marcnarc@xiplink.com> writes:
>
>>> The name of the command may be subject to discussions. I've chosen
>>> "run", but maybe "shell" would be OK too. In both cases, it doesn't
>>> allow the one-letter version since both "r" and "s" are already used.
>>
>> "exec" with one-letter "x"?
>
> Thanks, that sounds good, yes. Any other thought?
I like "exec".

I think the docs need to elaborate on the environment the "exec" command gets executed in, what's its current working directory for instance? Wherever I happened to run git-rebase from? the project root?

your if ! eval .. error message also exits with 0, surely that should exit with 1?

Previous: Matthieu MoyNext: Miles Bader
Message 9 of 27 in “rebase -i: add run command to launch a shell command”
  1. rebase -i: add run command to launch a shell commandMatthieu Moy, Jul 28, 2010
  2. Santi BéjarJul 28, 2010
  3. Matthieu MoyJul 28, 2010
  4. Matthieu MoyJul 30, 2010
  5. Marc BranchaudJul 30, 2010
  6. Matthieu MoyJul 30, 2010
  7. Neal KreitzingerJul 30, 2010
  8. Matthieu MoyJul 31, 2010
  9. Ævar Arnfjörð BjarmasonJul 31, 2010
  10. Miles BaderJul 31, 2010
  11. Matthieu MoyAug 2, 2010
  12. rebase -i: add exec command to launch a shell commandMatthieu Moy, Aug 2, 2010
  13. Jared HanceAug 2, 2010
  14. Ævar Arnfjörð BjarmasonAug 2, 2010
  15. Johannes SixtAug 6, 2010
  16. Matthieu MoyAug 7, 2010
  17. 1/2 rebase -i: add exec command to launch a shell commandMatthieu Moy, Aug 7, 2010
  18. 2/2 test-lib: user-friendly alternatives to test [!] [-d|-f]Matthieu Moy, Aug 7, 2010
  19. Paolo BonziniAug 2, 2010
  20. Junio C HamanoAug 2, 2010
  21. Matthieu MoyAug 3, 2010
  22. Kris ShannonAug 3, 2010
  23. Matthieu MoyAug 3, 2010
  24. Paolo BonziniJul 31, 2010
  25. Ævar Arnfjörð BjarmasonJul 31, 2010
  26. Jared HanceJul 31, 2010
  27. Jared HanceJul 31, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.