From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sat, 31 Jul 2010 13:56:09 GMT
Subject: Re: [RFC/PATCH] rebase -i: add run command to launch a shell command
Message-ID: <AANLkTikMW=ueQXfjpXk8G2FLRN55j1aJsnNz2w19BmkH@mail.gmail.com>
In-Reply-To: <vpqd3u53sd2.fsf@bauges.imag.fr>

On Fri, Jul 30, 2010 at 15:24, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Marc Branchaud <marcnarc@xiplink.com> writes:
>
>>> The name of the command may be subject to discussions. I've chosen
>>> "run", but maybe "shell" would be OK too. In both cases, it doesn't
>>> allow the one-letter version since both "r" and "s" are already used.
>>
>> "exec" with one-letter "x"?
>
> Thanks, that sounds good, yes. Any other thought?

I like "exec".

I think the docs need to elaborate on the environment the "exec"
command gets executed in, what's its current working directory for
instance? Wherever I happened to run git-rebase from? the project
root?

your if ! eval .. error message also exits with 0, surely that should
exit with 1?