git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] rebase -i: add run command to launch a shell command

From
Paolo Bonzini <bonzini@gnu.org>
Date
Aug 2, 2010, 15:04 UTC
Message-ID
<4C56DE68.7010906@gnu.org>
In-Reply-To
<vpqwrs9nxi5.fsf@bauges.imag.fr>
On 08/02/2010 12:02 PM, Matthieu Moy wrote:
> I think this makes more sense for the user, and I've actually already
> been biten by the old behavior, running "rebase -i" from a doc/
> subdirectory, and wondering why my "exec make" was rebuilding the
> code itself.

I think it's a matter of habits, and I would surely be bitten more by the opposite problem: when I'm usually ready to rebase and test I'm likely to be in src/ (for packages that have one such directory) or tests/.

cd to the top-level repository is a logical choice since rebase is a repository-wide command (even though the particular set of commits might touch only a part of it). It is easier to implement, does not have any problem with conflicts or otherwise with deletion, and easier to document as well.

If you decide to go with the other choice, however, I would _strongly_ suggest failing if the directory not exists. After all most of the time the command ("make" for example) will be pretty unlikely to succeed.

Paolo
Previous: Matthieu MoyNext: Junio C Hamano
Message 19 of 27 in “rebase -i: add run command to launch a shell command”
  1. rebase -i: add run command to launch a shell commandMatthieu Moy, Jul 28, 2010
  2. Santi BéjarJul 28, 2010
  3. Matthieu MoyJul 28, 2010
  4. Matthieu MoyJul 30, 2010
  5. Marc BranchaudJul 30, 2010
  6. Matthieu MoyJul 30, 2010
  7. Neal KreitzingerJul 30, 2010
  8. Matthieu MoyJul 31, 2010
  9. Ævar Arnfjörð BjarmasonJul 31, 2010
  10. Miles BaderJul 31, 2010
  11. Matthieu MoyAug 2, 2010
  12. rebase -i: add exec command to launch a shell commandMatthieu Moy, Aug 2, 2010
  13. Jared HanceAug 2, 2010
  14. Ævar Arnfjörð BjarmasonAug 2, 2010
  15. Johannes SixtAug 6, 2010
  16. Matthieu MoyAug 7, 2010
  17. 1/2 rebase -i: add exec command to launch a shell commandMatthieu Moy, Aug 7, 2010
  18. 2/2 test-lib: user-friendly alternatives to test [!] [-d|-f]Matthieu Moy, Aug 7, 2010
  19. Paolo BonziniAug 2, 2010
  20. Junio C HamanoAug 2, 2010
  21. Matthieu MoyAug 3, 2010
  22. Kris ShannonAug 3, 2010
  23. Matthieu MoyAug 3, 2010
  24. Paolo BonziniJul 31, 2010
  25. Ævar Arnfjörð BjarmasonJul 31, 2010
  26. Jared HanceJul 31, 2010
  27. Jared HanceJul 31, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.