git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase -i: add exec command to launch a shell command

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Aug 7, 2010, 08:48 UTC
Message-ID
<vpqeiealsez.fsf@bauges.imag.fr>
In-Reply-To
<201008062307.54841.j6t@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 5 quoted lines
> On Montag, 2. August 2010, Matthieu Moy wrote:
>> The typical usage pattern would be to run a test (or simply a compilation
>> command) at given points in history.
>
> What happens if the command modifies the worktree and/or the index?

Something terrible :-(. The next patch application fails, and the patch is more or less silently dropped (I thought it would fail giving the user an opportunity to fix and re-apply, but it doesn't).

New version checks working tree cleanness right after the command finishes, and stops cleanly, in time (restart with "git rebase --continue"). This comes with a new test.

(But the command can possibly create a new commit or amend the previous one without problem)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Johannes SixtNext: Matthieu Moy
Message 16 of 27 in “rebase -i: add run command to launch a shell command”
  1. rebase -i: add run command to launch a shell commandMatthieu Moy, Jul 28, 2010
  2. Santi BéjarJul 28, 2010
  3. Matthieu MoyJul 28, 2010
  4. Matthieu MoyJul 30, 2010
  5. Marc BranchaudJul 30, 2010
  6. Matthieu MoyJul 30, 2010
  7. Neal KreitzingerJul 30, 2010
  8. Matthieu MoyJul 31, 2010
  9. Ævar Arnfjörð BjarmasonJul 31, 2010
  10. Miles BaderJul 31, 2010
  11. Matthieu MoyAug 2, 2010
  12. rebase -i: add exec command to launch a shell commandMatthieu Moy, Aug 2, 2010
  13. Jared HanceAug 2, 2010
  14. Ævar Arnfjörð BjarmasonAug 2, 2010
  15. Johannes SixtAug 6, 2010
  16. Matthieu MoyAug 7, 2010
  17. 1/2 rebase -i: add exec command to launch a shell commandMatthieu Moy, Aug 7, 2010
  18. 2/2 test-lib: user-friendly alternatives to test [!] [-d|-f]Matthieu Moy, Aug 7, 2010
  19. Paolo BonziniAug 2, 2010
  20. Junio C HamanoAug 2, 2010
  21. Matthieu MoyAug 3, 2010
  22. Kris ShannonAug 3, 2010
  23. Matthieu MoyAug 3, 2010
  24. Paolo BonziniJul 31, 2010
  25. Ævar Arnfjörð BjarmasonJul 31, 2010
  26. Jared HanceJul 31, 2010
  27. Jared HanceJul 31, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.