git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [[PATCH v2]] Fix bug when more than one readline instance is used

From
Wesley <wesleys@opperschaap.net>
Date
Aug 11, 2023, 01:09 UTC
Message-ID
<8d683835-31d4-41f0-9d4e-90c95acbea28@opperschaap.net>
In-Reply-To
<xmqqcyzupf3b.fsf@gitster.g>
On 8/10/23 21:01, Junio C Hamano wrote:
Show 25 quoted lines
> Wesley Schwengle <wesleys@opperschaap.net> writes:
> 
> This line with "};" on it should not be added, I think.
> 
> cf. https://github.com/git/git/actions/runs/5827208598/job/15802787783#step:5:74
> 
>> +		return $term;
>>   	}
>>   }
> 
>   git-svn.perl | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index 93f6538d61..e919c3f172 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -307,7 +307,6 @@ package main;
>   		$term = $ENV{"GIT_SVN_NOTTY"}
>   				? new Term::ReadLine 'git-svn', \*STDIN, \*STDOUT
>   				: new Term::ReadLine 'git-svn';
> -		};
>   		return $term;
>   	}
>   }
You are 100% correct.

Cheers, Wesley

-- 
Wesley

Why not both?
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 14 in “Fix bug when more than one readline instance is used”
  1. Fix bug when more than one readline instance is usedWesley Schwengle, Aug 10, 2023
  2. Jeff KingAug 10, 2023
  3. ] Fix bug when more than one readline instance is usedWesley Schwengle, Aug 10, 2023
  4. Junio C HamanoAug 10, 2023
  5. WesleyAug 10, 2023
  6. Junio C HamanoAug 11, 2023
  7. WesleyAug 11, 2023
  8. Junio C HamanoAug 11, 2023
  9. Jeff KingAug 11, 2023
  10. Junio C HamanoAug 11, 2023
  11. git-svn: drop FakeTerm hackJunio C Hamano, Aug 30, 2023
  12. Jeff KingAug 31, 2023
  13. Junio C HamanoAug 31, 2023
  14. Junio C HamanoAug 10, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.