Re: [PATCH] git-svn: drop FakeTerm hack

From: Jeff King <peff@peff.net>
Date: Aug 31, 2023, 00:13 UTC
Message-ID: <20230831001325.GA2685726@coredump.intra.peff.net>
In-Reply-To: <xmqqa5u888lz.fsf_-_@gitster.g>

On Wed, Aug 30, 2023 at 03:32:08PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> > True.  Let me drop the patch from the 'next down to master
> > fast-track' candidate status.
> 
> We did the above but then everybody seems to have forgotten about
> it.  Let's resurrect the topic.  Here is my attempt.
> 
> ---- >8 ----
> From: Wesley Schwengle <wesleys@opperschaap.net>
> Subject: [PATCH] git-svn: drop FakeTerm hack
> 
> Drop the FakeTerm hack, just like dfd46bae (send-email: drop
> FakeTerm hack, 2023-08-08) did, for exactly the same reason.

Yep, it looks good to me.

Optionally you could add this to the commit message:

  It has been obsolete in git-svn since 30d45f798d (git-svn: delay term
  initialization, 2014-09-14). Note that unlike send-email, we already
  make sure to load Term::ReadLine only once. So this is just a cleanup,
  and not fixing any bug.

-Peff