Re: [PATCH] Fix bug when more than one readline instance is used

From: Jeff King <peff@peff.net>
Date: Aug 10, 2023, 00:49 UTC
Message-ID: <20230810004956.GA816605@coredump.intra.peff.net>
In-Reply-To: <20230810003939.1420306-1-wesleys@opperschaap.net>

On Wed, Aug 09, 2023 at 08:39:33PM -0400, Wesley Schwengle wrote:

Show 12 quoted lines

> The following error was emitted if one issued the command
> 
>     git send-email --compose 0001-my.patch
> 
> Can't locate object method "IN" via package "FakeTerm" at
> /home/wesleys/libexec/git-core/git-send-email line 997.
> 
> After added a warn in the relevant function that created the term it was
> obvious what happened:
> 
> Only one Term::ReadLine::Gnu instance is allowed. at
> /home/wesleys/libexec/git-core/git-send-email line 981.

I posted a similar fix yesterday, which is currently in 'next' via d42e4ca9f8:

  https://lore.kernel.org/git/20230808180935.GA2096901@coredump.intra.peff.net/

However...

> More or less the same logic happens in git-svn.perl so I fixed it there
> as well.

...I didn't touch git-svn.perl, and I agree it probably has the same problem (I didn't try it in practice, but any time ask() is called twice it will run into the same issue).

Do you want to prepare a patch on top removing the git-svn bits (probably all of FakeTerm, too)?

-Peff