Re: [PATCH] Fix bug when more than one readline instance is used

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 10, 2023, 01:05 UTC
Message-ID: <xmqqil9nk8pu.fsf@gitster.g>
In-Reply-To: <20230810003939.1420306-1-wesleys@opperschaap.net>

Wesley Schwengle <wesleys@opperschaap.net> writes:

If I recall correctly, this was fixed by Peff yesterday?

https://lore.kernel.org/git/20230808181531.GB2097200@coredump.intra.peff.net/

Show 16 quoted lines

> diff --git a/git-send-email.perl b/git-send-email.perl
> index affbb88509..7fdcf9084a 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -971,8 +971,10 @@ sub get_patch_subject {
>  	do_edit(@files);
>  }
>  
> +my $term;
>  sub term {
> -	my $term = eval {
> +	return $term if $term;
> +	$term = eval {
>  		require Term::ReadLine;
>  		$ENV{"GIT_SEND_EMAIL_NOTTY"}
>  			? Term::ReadLine->new('git-send-email', \*STDIN, \*STDOUT)

The patch I queued yesterday wraps this lexical inside another block to hide it from the outside, but otherwise it should achieve the same goal.