From: Wesley <wesleys@opperschaap.net>
Date: Fri, 11 Aug 2023 01:09:52 GMT
Subject: Re: [[PATCH v2]] Fix bug when more than one readline instance is used
Message-ID: <8d683835-31d4-41f0-9d4e-90c95acbea28@opperschaap.net>
In-Reply-To: <xmqqcyzupf3b.fsf@gitster.g>

On 8/10/23 21:01, Junio C Hamano wrote:
> Wesley Schwengle <wesleys@opperschaap.net> writes:
> 
> This line with "};" on it should not be added, I think.
> 
> cf. https://github.com/git/git/actions/runs/5827208598/job/15802787783#step:5:74
> 
>> +		return $term;
>>   	}
>>   }
> 
>   git-svn.perl | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index 93f6538d61..e919c3f172 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -307,7 +307,6 @@ package main;
>   		$term = $ENV{"GIT_SVN_NOTTY"}
>   				? new Term::ReadLine 'git-svn', \*STDIN, \*STDOUT
>   				: new Term::ReadLine 'git-svn';
> -		};
>   		return $term;
>   	}
>   }

You are 100% correct.

Cheers,
Wesley

-- 
Wesley

Why not both?